Task/tcdizm 364/fix config fields in data filter#136
Merged
timothygachengo merged 7 commits intoMay 14, 2026
Conversation
- Display "Select Filter" section immediately when app is selected instead of waiting for filters to load
- Add loading state ("Loading filter options...") while API metadata is being fetched
- Add null/undefined checks for this.state.filters to prevent errors during loading
- Apply fixes to both non-API and CSV filter sections
- Guard DataFilters component rendering with filters existence check
This fixes the issue where Zambia blocks had no filter configuration options visible on initial load, making the filter appear useless until the user changed the app. Ethiopia worked because it had a default app pre-configured.
There was a problem hiding this comment.
Pull request overview
Fixes the filter block editor UI so configuration fields render even while filter metadata is still loading, and adds a GitHub Actions workflow intended to run pnpm run build on pull requests.
Changes:
- Render the “Select Filter” panel for non-CSV apps even when filter options haven’t loaded yet (shows a loading state).
- Tighten some equality checks and guard
DataFiltersrendering until filter metadata is available. - Add a PR workflow to run
pnpm run build.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| plugins/wp-react-blocks-plugin/blocks/filter/BlockEdit.js | Adjusts editor-side conditional rendering/loading behavior for filter configuration panels. |
| .github/workflows/test-on-pr.yml | Adds a pull-request CI workflow to run the monorepo build. |
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
…thub.com:devgateway/data-viz-wordpress into task/TCDIZM-364/fix-config-fields-in-data-filter
sdimunzio
approved these changes
May 13, 2026
timothygachengo
deleted the
task/TCDIZM-364/fix-config-fields-in-data-filter
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
pnpm buildwhen a PR is opened.Type of change
fix:)feat:)BREAKING CHANGE:)refactor:/chore:)docs:)Affected package(s)
@devgateway/dvz-wp-commons@devgateway/create-wp-customizer@devgateway/upgrade-wp-customizerplugins/wp-react-blocks-pluginplugins/wp-react-custom-apiplugins/wp-react-custom-rest-menuChecklist
pnpm changeset) for any change to a published packagepnpm buildpasses locally